[FrameworkBundle] Skip auto-validation for empty auto_mapping #44698
Conversation
|
Hey! I think @jschaedl has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
There was a problem hiding this comment.
Sorry, can't dig much right now, but, with this patch, would:
framework:
validation:
auto_mapping: []still allow enabling auto mapping per-case by adding the @Assert\EnableAutoMapping annotation/attribute ?
And would
framework:
validation:
auto_mapping:
App\Entity\: []still auto validate App\Entity\ ns while requiring to add @Assert\EnableAutoMapping for the other ns?
IIRC, this would be the expected behavior.
src/Symfony/Component/Validator/DependencyInjection/AddAutoMappingConfigurationPass.php
Show resolved
Hide resolved
…pingConfigurationPass.php Co-authored-by: Maxime Steinhausser <[email protected]>
yeah, no 😭 What bugs me more at this point is why nobody is noticing. That includes me now. |
|
Probably related? I had this kind of issue a long time ago... |
I can confirm this fixes the issue on our side at 4.4.
I created this PR mostly to see what tests do on your side. 🤞 I'm not planning to digest this feature any further :)
I let you decide as of which branch to disable auto-validation ;)