-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Workflow] Added generic template in Event and his inheritors #44702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workflow] Added generic template in Event and his inheritors #44702
Conversation
It's already reviewed, something strange was broken my fork. #44622 |
To get rid of the error on the /**
* {@inheritdoc}
*
* @param TSubject $subject
*/
public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow = null, array $context = []) |
…ent::$subject`, `Event::getSubject()` and `Event::__constructor`
Thanks, resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure is legit.
Please don't forget to patch the .github/expected-missing-return-types.diff
file as done eg in #44695 (see the file for how)
Note that since DebugClassLoader is not able to understand the @template
annotations (yet), I added a hack in 1dad23b
We're going to need something similar here (or to patch DebugClassLoader before merging.)
Good idea, i will check how i can do it in this case. |
Can't find solution for your suggestion. I close PR. |
Added generic template for
Event
in Workflow ComponentAdded generic template for
Event
,Event::$subject
andEvent::getSubject()
for PHPStorm support.