Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] fix Email HTML preview #44714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2021
Merged

[WebProfilerBundle] fix Email HTML preview #44714

merged 1 commit into from
Dec 21, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Dec 19, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44696 Fix #44703
License MIT

First issue:

When swapping the order of base64 & charset=utf-8 it works well
Friendly ping @lyrixx as PR author

Second issue:

Friendly ping @Art4 as issue author

As the Mime\Email is:

    /**
     * @return resource|string|null
     */
    public function getHtmlBody()
    {
        return $this->html;
    }

@carsonbot carsonbot added this to the 6.1 milestone Dec 19, 2021
@carsonbot carsonbot changed the title [Profiler] fix HTML preview for null html body [WebProfilerBundle] fix HTML preview for null html body Dec 19, 2021
@94noni 94noni changed the base branch from 6.1 to 5.4 December 19, 2021 17:53
@94noni 94noni changed the title [WebProfilerBundle] fix HTML preview for null html body [WebProfilerBundle] fix HTML preview Dec 19, 2021
@94noni 94noni changed the title [WebProfilerBundle] fix HTML preview [WebProfilerBundle] fix Email HTML preview Dec 19, 2021
@94noni 94noni force-pushed the fx-profiler-mail branch 2 times, most recently from c7773cf to 1116948 Compare December 19, 2021 20:00
@fabpot fabpot modified the milestones: 6.1, 5.4 Dec 21, 2021
@fabpot
Copy link
Member

fabpot commented Dec 21, 2021

Thank you @94noni.

@fabpot fabpot merged commit a42dbe3 into symfony:5.4 Dec 21, 2021
@94noni 94noni deleted the fx-profiler-mail branch December 22, 2021 05:26
This was referenced Dec 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Art4 Art4 Art4 left review comments

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@94noni @fabpot @lyrixx @stof @Art4 @carsonbot