Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpClient] fix checking for recent curl consts #44743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2021
Merged

[HttpClient] fix checking for recent curl consts #44743

merged 1 commit into from
Dec 22, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42061
License MIT
Doc PR -

@carsonbot carsonbot added this to the 5.3 milestone Dec 21, 2021
derrabus
derrabus approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this PR fixes compatibility with libcurl versions older than 7.39.0 which was released in 2014! Enterprise Linux ftw. 🙈

@stof
Copy link
Member

stof commented Dec 21, 2021

@derrabus quoted from https://www.php.net/manual/en/curl.requirements.php:

PHP requires libcurl version 7.10.5 or later.

@stof
Copy link
Member

stof commented Dec 21, 2021 •
edited
Loading

based on https://github.com/php/php-src/blob/0b5d371a9c2652c9775d807d29658b59a71848e5/ext/curl/sync-constants.php#L15, that doc seems outdated though. the min version seems to be 7.15.5 now. But that's still very old.

Edit: fixed the doc in php/doc-en#1221

@derrabus
Copy link
Member

Yeah, I know. But still. 🙈

@nicolas-grekas nicolas-grekas merged commit 6b8b4ab into symfony:5.3 Dec 22, 2021
@nicolas-grekas nicolas-grekas deleted the hc-curl-check branch December 29, 2021 09:46
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @stof @derrabus @carsonbot