Add Parameter attribute to bind container parameters to services.

symfony · maldoinc · Dec 23, 2021 · Jan 15, 2022 · 94d681c6a72244dbe314b0310b545bd07f8eb83b · nicolas-grekas
commit 94d681c6a72244dbe314b0310b545bd07f8eb83b
diff --git a/src/Symfony/Component/DependencyInjection/Attribute/Parameter.php b/src/Symfony/Component/DependencyInjection/Attribute/Parameter.php
@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\DependencyInjection\Attribute;
+
+#[\Attribute(\Attribute::TARGET_PARAMETER)]
+class Parameter
+{
+    public function __construct(public string $name)
+    {
+    }
+}
@@ -14,6 +14,7 @@
 use Symfony\Component\Config\Resource\ClassExistenceResource;
 use Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument;
 use Symfony\Component\DependencyInjection\Argument\TaggedIteratorArgument;
+use Symfony\Component\DependencyInjection\Attribute\Parameter;
 use Symfony\Component\DependencyInjection\Attribute\TaggedIterator;
 use Symfony\Component\DependencyInjection\Attribute\TaggedLocator;
 use Symfony\Component\DependencyInjection\Attribute\Target;
@@ -256,6 +257,12 @@ private function autowireMethod(\ReflectionFunctionAbstract $reflectionMethod, a
                         $arguments[$index] = new ServiceLocatorArgument(new TaggedIteratorArgument($attribute->tag, $attribute->indexAttribute, $attribute->defaultIndexMethod, true, $attribute->defaultPriorityMethod));
                         break;
                     }
+
+                    if (Parameter::class === $attribute->getName()) {
+                        $attribute = $attribute->newInstance();
+                        $arguments[$index] = $this->container->getParameter($attribute->name);
+                        break;
+                    }
                 }
 
                 if ('' !== ($arguments[$index] ?? '')) {

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -38,6 +38,27 @@
  */
 class AutowirePassTest extends TestCase
 {
+    /**
+     * @requires PHP 8.0
+     */
+    public function testParameterBindingsSuccess()
+    {
+        $container = new ContainerBuilder();
+
+        $testDefinition = $container->register(AutowiredParameterTest::class);
+        $testDefinition->setAutowired(true);
+
+        $container->setParameter('parameter.test', 'hello world');
+
+        (new ResolveClassPass())->process($container);
+        (new AutowirePass())->process($container);
+        $definition = $container->getDefinition(AutowiredParameterTest::class);
+
+        $this->assertCount(1, $definition->getArguments());
+        $this->assertEquals('hello world', $definition->getArgument(0));
+        $this->assertEquals('hello world', $container->get(AutowiredParameterTest::class)->testParam);
+    }
+
     public function testProcess()
     {
         $container = new ContainerBuilder();

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php
@@ -2,6 +2,7 @@
 
 namespace Symfony\Component\DependencyInjection\Tests\Compiler;
 
+use Symfony\Component\DependencyInjection\Attribute\Parameter;
 use Symfony\Contracts\Service\Attribute\Required;
 
 class AutowireSetter
@@ -26,3 +27,10 @@ class AutowireProperty
     #[Required]
     public Foo $foo;
 }
+
+class AutowiredParameterTest
+{
+    public function __construct(#[Parameter("parameter.test")] public string $testParam)
+    {
+    }
+}