[Translation] [LocoProvider] Use rawurlencode and separate tag setting #44816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4462567 to
b694858
Compare
nicolas-grekas
approved these changes
Dec 28, 2021
|
Thank you @danut007ro. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Loco documentation when setting tag to multiple assets, the ids must be comma separated. Because local translation ids can contain comma, I handle separately those ids and add tag one by one.
I also added
rawurlencodefor every request made to Loco. It was already used once inside thereadmethod, but I added it everywhere.