MailerInterface: failed exception contract when enabling messenger #44839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface for MailerInterface::send states that exception for transport failures are sent as TransportExceptionInterface, which make perfectly sense and allows to create solid UI. If at later stage the Messenger component is enabled, the mail will be rewired into a dispatched message, which by default is synchronous. This cause all exception to be wrapped into HandlerFailedException which doesn't the interface contract. In the end the UI is broken, and the exception HandlerFailedException, even if caught, is totally unrelated to the usage context as it is only related to configuration details. This patch will unwrap the underlying MailTransportInterface exception if available for the handler exception.
fabpot
approved these changes
Feb 25, 2022
|
Thank you @giosh94mhz. |
This was referenced Feb 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface for MailerInterface::send states that exception for
transport failures are sent as TransportExceptionInterface, which
make perfectly sense and allows to create solid UI.
If at later stage the Messenger component is enabled, the mail will
be rewired into a dispatched message, which by default is synchronous.
This cause all exception to be wrapped into HandlerFailedException
which doesn't the interface contract.
In the end the UI is broken, and the exception HandlerFailedException,
even if caught, is totally unrelated to the usage context as it is only
related to configuration details.
This patch will unwrap the underlying MailTransportInterface exception
if available for the handler exception.
PS: don't know if make sense to add a phpunit test for this cross-component scenario, if so I'll try. Also, this will restore compatibility with interface, but I don't if it's to be considered a BC (strictly speaking, it may be)