[Console] Fix compact table style to avoid outputting a leading space #44915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no change to the testsuite ? this looks suspicious to me |
|
I'll fix the tests if this is acceptable. Sorry but don't want to waste time on that if it's going to be closed due to being seen as BC break. |
|
That works for me! Please, go ahead with the tests :) |
|
@Seldaek Any news? |
|
Sorry, got lost in the inbox.. Rebased and fixed TableTest now. |
chalasr
approved these changes
Mar 16, 2022
|
Thank you @Seldaek. |
This was referenced Apr 2, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
compactoutput from:To:
Note the only difference is the leading space which is not there anymore.
IMO this is a much better default, but I do understand it changes something which has been as it is for ages, which may be considered a BC break more than a bugfix.