[browser kit] Client now stores filtered response after request.#4497
Merged
Conversation
Member
|
This is as BC break as it changes the class returned by the method, even if the BC break is a bugfix to respect the epxected behavior :) |
Contributor
Author
|
@stof you're right! |
Member
|
@jfsimon can you add a note in the changelog of the component and in the upgrade file ? |
Contributor
Author
|
@stof done! |
Member
|
@fabpot 👍 |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2012
Commits ------- 06976fc Updated upgrade 2.1 file. 110ccd8 [BrowserKit] Updated changelog. 686854b [http kernel] Added client response type test. ce7e1e6 [browser kit] Client now stores filtered response after request. Discussion ---------- [browser kit] Client now stores filtered response after request. Bug fix: yes Feature addition: no Backwards compatibility break: yes/no, choice is your Symfony2 tests pass: yes `Symfony\Component\HttpKernel\Client::request()` method now returns a `Symfony\Component\BrowserKit\Response` instance. Fixes issue #4475. --------------------------------------------------------------------------- by stof at 2012-06-05T08:58:00Z This *is* as BC break as it changes the class returned by the method, even if the BC break is a bugfix to respect the epxected behavior :) --------------------------------------------------------------------------- by jfsimon at 2012-06-05T09:05:32Z @stof you're right! --------------------------------------------------------------------------- by travisbot at 2012-06-06T15:29:54Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1533533) (merged 686854b into 1541fe2). --------------------------------------------------------------------------- by stof at 2012-06-09T10:12:18Z @jfsimon can you add a note in the changelog of the component and in the upgrade file ? --------------------------------------------------------------------------- by jfsimon at 2012-06-09T10:51:00Z @stof done! --------------------------------------------------------------------------- by travisbot at 2012-06-09T11:12:43Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1575524) (merged 06976fc into 1541fe2). --------------------------------------------------------------------------- by stof at 2012-06-09T12:50:16Z @fabpot 👍
stof
added a commit
to stof/symfony-docs
that referenced
this pull request
Jun 9, 2012
fabpot
added a commit
that referenced
this pull request
Jun 9, 2012
Member
|
@fabpot why reverting it ? |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 17, 2012
Updated the doc for symfony/symfony#4497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: yes/no, choice is your
Symfony2 tests pass: yes
Symfony\Component\HttpKernel\Client::request()method now returns aSymfony\Component\BrowserKit\Responseinstance.Fixes issue #4475.