[Runtime] Fix --env and --no-debug with dotenv_overload#44997
Merged
Conversation
c6b65cb to
f91f18b
Compare
GromNaN
reviewed
Jan 12, 2022
fb41341 to
97a5714
Compare
chalasr
approved these changes
Jan 26, 2022
97a5714 to
0afd743
Compare
0afd743 to
0460f81
Compare
Member
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 15, 2022
This PR was merged into the 5.4 branch. Discussion ---------- [Runtime] Fix dotenv_overload with commands | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - Fixes bugs introduced in #44997. For example, if `$_SERVER['APP_ENV'] = 'foo';` exists and with `APP_ENV=prod` in `.env`, any command will throw `Cannot use "--env" or "-e" when the...` because `foo` is considered as the input env. Determining the input env and debug from `$_SERVER` is wrong because when the `--no-debug` and `--env` are not used, we actually consider the existing env and debug as the input end and debug. We need to know and use the real input env and debug. Commits ------- 4075269 [Runtime] Fix dotenv_overload with commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
dotenv_overloadoption enabled, commands--no-debugand--env=prodoptions are not honored.