[DoctrineBridge] Fix invalid guess with enumType#45012
Merged
Merged
Conversation
ff5d94d to
8171050
Compare
8171050 to
dd632d5
Compare
dd632d5 to
68dd218
Compare
|
I was playing with the last version of Doctrine this afternoon and ran into this exact issue. This also prevent the Serializer to correctly denormalize an object which one of its property is an enum. I was looking for a way to fix this but you were faster. Anyway, I tried your patch and it works like a charm, thank you 👌 ! |
stof
approved these changes
Jan 13, 2022
ogizanagi
approved these changes
Jan 13, 2022
Member
|
Thank you @jderusse. |
Member
|
Thank you! 🙂 |
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since doctrine/orm#9304 doctrine allows Enums with the new
enumTypeoption.ie.
The issue is, it break validations at several places:
doctrinerExtractorguess it's astring(Because oftype = string), and validation adds the constraintAssert\Type(string)doctrineLoaderguess it's a string with a maxLength and validation adds a constrainAssert\Length(max=1)