[ErrorHandler] ignore @return when there is an @template
#45043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it also needs to handle class-level |
94dd9fe to
d1aa509
Compare
|
@stof right, updated. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 18, 2022
…late`` (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [ErrorHandler] ignore ``@return`` when there is an ``@template`` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - And update .github/expected-missing-return-types.diff Commits ------- d1aa509 [ErrorHandler] ignore ``@return`` when there is an ``@template``
nicolas-grekas
added a commit
that referenced
this pull request
Mar 18, 2022
* 5.4: bug #45043 [ErrorHandler] ignore ``@return`` when there is an ``@template`` (nicolas-grekas) [Finder] fix tests on Windows
nicolas-grekas
added a commit
that referenced
this pull request
Mar 18, 2022
* 6.0: bug #45043 [ErrorHandler] ignore ``@return`` when there is an ``@template`` (nicolas-grekas) [Finder] fix tests on Windows
PhilETaylor
pushed a commit
to PhilETaylor/symfony
that referenced
this pull request
Sep 6, 2023
…``@template`` (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [ErrorHandler] ignore ``@return`` when there is an ``@template`` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - And update .github/expected-missing-return-types.diff Commits ------- d1aa509 [ErrorHandler] ignore ``@return`` when there is an ``@template``
PhilETaylor
pushed a commit
to PhilETaylor/symfony
that referenced
this pull request
Sep 6, 2023
* 5.4: bug symfony#45043 [ErrorHandler] ignore ``@return`` when there is an ``@template`` (nicolas-grekas) [Finder] fix tests on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update .github/expected-missing-return-types.diff