Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removing unnecessary space #45055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Removing unnecessary space #45055

merged 1 commit into from
Jan 18, 2022

Conversation

axzx
Copy link
Contributor

@axzx axzx commented Jan 18, 2022

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
License MIT

@axzx axzx requested a review from OskarStark as a code owner January 18, 2022 10:14
@carsonbot carsonbot added this to the 6.1 milestone Jan 18, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@GromNaN
Copy link
Member

GromNaN commented Jan 18, 2022

Thanks @axzx.

@GromNaN GromNaN merged commit 1317e39 into symfony:6.1 Jan 18, 2022
@axzx axzx deleted the patch-1 branch January 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants