[Notifier] Use the UTF-8 encoding in smsapi-notifier#45174
Merged
Conversation
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
OskarStark
approved these changes
Jan 25, 2022
Contributor
OskarStark
left a comment
There was a problem hiding this comment.
Please add a changeling entry, thanks
Member
|
@OskarStark we don't add changelog entries manually for bugfixes in patch releases |
Contributor
Author
|
@stof @OskarStark so I've reverted it |
Contributor
|
@stof sorry you are right |
OskarStark
approved these changes
Jan 26, 2022
stof
approved these changes
Jan 26, 2022
Member
|
Thank you @marphi. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2022
…ssage with the highest priority (marphi) This PR was squashed before being merged into the 6.1 branch. Discussion ---------- [Notifier] smsapi-notifier `fast` option to sending message with the highest priority | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- I have used custom solution to send sms via smsapi for many years. Time to rewrite it to notifier component. Found 2 issues from my point of view: 1. THIS part is splitted into separate PR #45174. ~~Encoding. Currently `smsapi-notifier` does not specify `encoding` in payload request to provider api which generates such errors.  (sms message with invalid encoding) api.smsapi.pl use `windows-1250` as a default value. I propose to set explicitly `utf-8`. After changes:~~  2. I'm using smsapi to sending auth codes to my clients. In this case is really important to send SMS as fast as possible, `fast` options allow me to do this otherwise messages might have some delays. Commits ------- cd266a0 [Notifier] smsapi-notifier `fast` option to sending message with the highest priority
This was referenced Jan 28, 2022
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS PR is splitted version of PR #45139 (see discussion)
Currently smsapi-notifier does not specify encoding in payload request to provider api which generates such errors.
(sms message with invalid encoding)
api.smsapi.pl use windows-1250 as a default value. I propose to set explicitly
utf-8.After changes: