Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel][WebProfilerBundle] Fixed error count by log not displayed in WebProfilerBundle #45302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

SVillette
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45183
License MIT
Doc PR -

This PR is the following of #45198. Refer to this PR for details.

image

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checked this change in a real Symfony app, and it worked for me 👍

Thanks @SVillette!

@SVillette
Copy link
Contributor Author

SVillette commented Feb 4, 2022

Thanks @javiereguiluz for your review.

I've run the tests on my local for HttpKernel component and it's all green, any idea why continuous-integration/appveyor/pr failed on HttpFoundation ?

@fabpot
Copy link
Member

fabpot commented Feb 4, 2022

Thank you @SVillette.

@fabpot fabpot merged commit 5cb5880 into symfony:5.4 Feb 4, 2022
@SVillette SVillette deleted the fix_45183 branch February 4, 2022 08:13
This was referenced Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants