Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Fix ignored callbacks in denormalization #45323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

[Serializer] Fix ignored callbacks in denormalization #45323

merged 1 commit into from
Feb 11, 2022

Conversation

benjaminmal
Copy link

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43563-2
License MIT
Doc PR -

Stop ignoring callbacks in denormalization. #freeTheCallbacks!!!

@benjaminmal benjaminmal requested a review from dunglas as a code owner February 5, 2022 16:51
@carsonbot carsonbot added this to the 4.4 milestone Feb 5, 2022
@carsonbot
Copy link

Hey!

I think @Th3Mouk has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

dunglas
dunglas approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of deprecating the callbacks and recommending using custom normalizers instead and I would revert the changes made to the PHPDoc for consistency, otherwise +1.

@nicolas-grekas
Copy link
Member

Thank you @benjaminmal.

@nicolas-grekas nicolas-grekas merged commit 7fd9127 into symfony:4.4 Feb 11, 2022
@nicolas-grekas
Copy link
Member

I just found that this is already deprecated and removed from 5.4.

@nicolas-grekas
Copy link
Member

Hum, only setCallbacks() is deprecated, my bad.

@benjaminmal benjaminmal deleted the ticket_43563 branch February 11, 2022 16:19
This was referenced Feb 28, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminmal @carsonbot @nicolas-grekas @dunglas