[SecurityBundle] Remove autoconfiguration for ProcessorInterface
#45422
Conversation
ProcessorInterfaceProcessorInterface
fb94f3a to
33553ee
Compare
|
I guess that's a wrong namespace, maybe related to history/renames? |
The pass was added in #33663 and those lines haven't changed since then. I've browsed the source tree that very commit but the bridge did not have that interface at that time either. I dug deeper and apparently, the interface did exist for a brief moment: Introduced in #27801, reverted in #28845. I assume that the lines are an artifact of an earlier iteration of that PR. Since they effectively never did anything, the fix for me is to remove them. |
|
The purpose of those lines was to wire processors automatically with the untracked token storage, so that they could log things found in the session without triggering We should fix this behavior of it's broken. |
|
Should we build that logic in MonologBundle instead? |
|
I was having a look, monolog bundle already registers the tag for autoconfiguration: What this does is the binding. And we could argue that the binding is for SecurityBundle. To me, we should fix the namespace in the lowest affected branch. |
…terface (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [SecurityBundle] fix autoconfiguring Monolog's ProcessorInterface | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #45422 | License | MIT | Doc PR | - Commits ------- 7712d80 [SecurityBundle] fix autoconfiguring Monolog's ProcessorInterface
This PR removes autoconfiguration logic for a
Symfony\Bridge\Monolog\Processor\ProcessorInterfacethat does not exist. As far as I can tell, this has always been unused code, so we might as well remove it.