Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix table header seperator wrapping #45565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2022
Merged

Fix table header seperator wrapping #45565

merged 1 commit into from
Apr 9, 2022

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Feb 26, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45520
License MIT
Doc PR

Before PR, a new seperator is added foreach split line in header

        $table = new Table();
        $table
            ->setHeaders([
                [
                    'Publication',
                    'Very long header with a lot of information',
                ],
            ])
            ->setRows([
                [
                    '1954',
                    'The Lord of the Rings, by J.R.R. Tolkien',
                ],
            ])
            ->setColumnMaxWidth(1, 30);

Before PR:

image

After PR
image

(Fabbot cannot be green (break unit tests))

@alamirault alamirault requested a review from chalasr as a code owner February 26, 2022 13:34
@carsonbot carsonbot added this to the 6.1 milestone Feb 26, 2022
@alamirault alamirault changed the title Fix table header seperator wrapping [Console] Fix table header seperator wrapping Feb 26, 2022
@alamirault alamirault changed the base branch from 6.1 to 5.4 February 26, 2022 13:35
@alamirault alamirault force-pushed the fix-table-header-seperator-wrapping branch from 86c31d2 to 9ee4440 Compare February 26, 2022 13:40
@carsonbot
Copy link

Hey!

I think @a1812 has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@alamirault
Copy link
Contributor Author

Any feedback on this PR will be appreciated. Thanks

chalasr
chalasr requested changes Apr 7, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor comments.
I think the bug exists on 4.4 as well, can you confirm and rebase if it's the case?

@carsonbot carsonbot changed the title [Console] Fix table header seperator wrapping Fix table header seperator wrapping Apr 7, 2022
@alamirault alamirault force-pushed the fix-table-header-seperator-wrapping branch from 9ee4440 to ebf38b1 Compare April 9, 2022 16:27
@alamirault alamirault changed the base branch from 5.4 to 4.4 April 9, 2022 16:28
@alamirault alamirault requested a review from chalasr April 9, 2022 16:35
@fabpot fabpot modified the milestones: 6.1, 4.4 Apr 9, 2022
@fabpot
Copy link
Member

fabpot commented Apr 9, 2022

Thank you @alamirault.

@fabpot fabpot merged commit 69f7f6e into symfony:4.4 Apr 9, 2022
This was referenced Apr 27, 2022
Merged
Merged
Merged
GromNaN added a commit to GromNaN/symfony that referenced this pull request May 9, 2022
@GromNaN
Fix CS in Console Table after symfony#45565
d3d72ae
nicolas-grekas added a commit that referenced this pull request May 10, 2022
@nicolas-grekas
minor #46300 [Console] Fix CS in Table class after #45565 (GromNaN)
0437e3a 
This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Fix CS in Table class after #45565

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Indentation issue introduced by [#45565](https://github.com/symfony/symfony/pull/45565/files#diff-879e34698fd4acc2bbbb1e2c9ca2f0daf8f499a1123e4c0fc58dc68895724a91R760-R764)

Commits
-------

d3d72ae Fix CS in Console Table after #45565
nicolas-grekas added a commit that referenced this pull request May 10, 2022
@nicolas-grekas
Merge branch '4.4' into 5.4
8d028be 
* 4.4:
  [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false
  [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context
  [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2
  Fix CS in Console Table after #45565
  fix italian translation for validators
nicolas-grekas added a commit that referenced this pull request May 10, 2022
@nicolas-grekas
Merge branch '5.4' into 6.0
9284712 
* 5.4:
  [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false
  [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context
  [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2
  [ErrorHandler] Fix list of tentative return types
  Fix CS in Console Table after #45565
  Suppress unhandled error in some specific use-cases.
  fix italian translation for validators
nicolas-grekas added a commit that referenced this pull request May 10, 2022
@nicolas-grekas
Merge branch '6.0' into 6.1
aad3e78 
* 6.0:
  [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false
  [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context
  [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2
  [ErrorHandler] Fix list of tentative return types
  Fix CS in Console Table after #45565
  Suppress unhandled error in some specific use-cases.
  fix italian translation for validators
@alamirault alamirault deleted the fix-table-header-seperator-wrapping branch August 7, 2022 17:21
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@nicolas-grekas
Merge branch '5.4' into 6.0
838e33a 
* 5.4:
  [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false
  [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context
  [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2
  [ErrorHandler] Fix list of tentative return types
  Fix CS in Console Table after symfony#45565
  Suppress unhandled error in some specific use-cases.
  fix italian translation for validators
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull request Sep 6, 2023
@nicolas-grekas
Merge branch '6.0' into 6.1
5ba1bb7 
* 6.0:
  [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false
  [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context
  [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2
  [ErrorHandler] Fix list of tentative return types
  Fix CS in Console Table after symfony#45565
  Suppress unhandled error in some specific use-cases.
  fix italian translation for validators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Console] setColumnMaxWidth does not wrap header cells nicely
4 participants
@alamirault @carsonbot @fabpot @chalasr