[DependencyInjection] add a Service attribute to explicitly choose the injected service id
#45573
Conversation
|
I think it could be nice to have a class MyService
{
public function __construct(
#[Bind('@=service("App\\Mail\\MailerConfiguration").getMailerMethod()')
private $service1,
#[Bind('@some_service')]
private $service2,
#[Service('some_service')]
private $service3, // equivalent to above
#[Bind('%env(json:file:resolve:AUTH_FILE)%')]
private $parameter1,
#[Bind('%kernel.project_dir%/config/dir')]
private $parameter2,
#[Bind('%kernel.project_dir%')]
private $parameter3,
#[Parameter('kernel.project_dir')]
private $parameter4, // equivalent to above
) {}
}
|
|
Hey! I think @ruudk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
There was a problem hiding this comment.
The implementation and the feature looks fine to me, but there is still this to resolve:
I think it could be nice to have a Bind attribute that allows any yaml syntax to be used:
I would name this #[Autowire], because this wouldn't work like a binding.
If we go with a parameter that supports this yaml-like syntax, we don't need neither Service nor Parameter so both proposals are exclusive to me.
With #44780, we're going to support pretty much everything that this yaml syntax would provide. Only expressions would be missing, and supporting them is only a matter of sending a PR adding a new #[Expression] attribute.
So we have a choice to make to me, which supporting #[Autowire]+yaml-like XOR Parameter+Service+Expression.
If we go with the latter, I'm wondering if we shouldn't prefix them with Autowire for clarity and disambiguation: AutowireService, AutowireParameter and AutowireExpression.
Note that we already have #[TaggedIterator] and #[TaggedLocator].
|
I personally prefer a single I still think service/parameter/expression sub-classes could be useful/more explicit but don't feel very strongly about this. Discussion for the future. |
|
Closing in favor of #45657 |
…te (kbond) This PR was merged into the 6.1 branch. Discussion ---------- [DependencyInjection] add `Autowire` parameter attribute | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | todo Replaces #45573 & #44780 with a single new `Autowire` attribute: ```php class MyService { public function __construct( #[Autowire(service: 'some_service')] private $service1, #[Autowire(expression: 'service("App\\Mail\\MailerConfiguration").getMailerMethod()') private $service2, #[Autowire(value: '%env(json:file:resolve:AUTH_FILE)%')] private $parameter1, #[Autowire(value: '%kernel.project_dir%/config/dir')] private $parameter2, ) {} } ``` Works with controller arguments as well: ```php class MyController { public function someAction( #[Autowire(service: 'some_service')] $service1, #[Autowire(expression: 'service("App\\Mail\\MailerConfiguration").getMailerMethod()') $service2, #[Autowire(value: '%env(json:file:resolve:AUTH_FILE)%')] $parameter1, #[Autowire(value: '%kernel.project_dir%/config/dir')] $parameter2, ): Response {} } ``` Commits ------- d43fe42 [DependencyInjection] add `Autowire` parameter attribute
This is a sister PR to #44780. This removes the need to reach for a separate config file when needing to inject a service with a specific service id. This could be used as a less brittle alternative to the
Targetattribute.TODO