[Process] Don't return executable directories in PhpExecutableFinder #45676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c7daa1 to
947152b
Compare
fancyweb
commented
Mar 8, 2022
| } | ||
| } | ||
|
|
||
| public function testFindWithExecutableDirectory() |
There was a problem hiding this comment.
Only the first change is tested (PHP_BINARY env var). The rest is hard to test since we are in cli mode 😓
nicolas-grekas
approved these changes
Mar 9, 2022
fabpot
approved these changes
Mar 12, 2022
|
Thank you @fancyweb. |
This was referenced Apr 2, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directories can be executable and be wrongly returned if some env vars have directory paths as their values.