Thanks to visit codestin.com
Credit goes to github.com

Skip to content

typehint of DkimOptions algorithm wrong #45719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Conversation

markusramsak
Copy link
Contributor

@markusramsak markusramsak commented Mar 11, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #45685
License MIT
Doc PR -

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fancyweb
Copy link
Contributor

Can you please edit the PR description to add at the end:

| License       | MIT
| Doc PR        | -

see https://fabbot.io/report/symfony/symfony/45719/1468c5b0c0929683dc74b7a55ce8a6ac8d720bd9

@fabpot
Copy link
Member

fabpot commented Mar 12, 2022

Thank you @markusramsak.

@fabpot fabpot merged commit b51ce8e into symfony:5.4 Mar 12, 2022
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants