[Lock] SemaphoreStore catching exception from sem_get #45737
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -64,21 +64,40 @@ private function lock(Key $key, bool $blocking) | |||
| } | |||
|
|
|||
| $keyId = unpack('i', md5($key, true))[1]; | |||
| $resource = sem_get($keyId); | |||
There was a problem hiding this comment.
the ErrorException originates from a php warning
instead, I suggest using this (and removing the new method):
$resource = @sem_get($keyId);
$acquired = $resource && @sem_acquire($resource, !$blocking);There was a problem hiding this comment.
I was not sure if @ operator can suspend exceptions, this looks nice. I go change this.
…venting of error: identifier removed
|
Thank you @Triplkrypl. |
We use on project symfony/lock and I found exception in our monitoring from
sem_getPHP function.Function
sem_getis called beforesem_acquireso resource is not locked andsem_getfunction call can run in same time as some code with locked resource in another process where removing semaphpore going on by functionsem_remove.PHP: 7.4.13
symfony/lock: 5.3.4
Exceptions:
Symfony\Component\Lock\Exception\LockAcquiringExceptionFailed to acquire the "some_our_resource_key" lock.
ErrorExceptionsem_get(): failed for key 0xffffffffb8cf1ec4: Identifier removed