[Translation] [LocoProvider] Add content-type for POST translations #45791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomasz-kusy
commented
Mar 19, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #44031 |
| License | MIT |
| #44031 |
|
Hey! I think @Kocal has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Kocal
approved these changes
Mar 20, 2022
fabpot
added a commit
that referenced
this pull request
Mar 23, 2022
…colas-grekas) This PR was merged into the 6.1 branch. Discussion ---------- [HttpClient] Improve default content-type handling | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes (minor) | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This improves the default behavior of handling the content-type header: with this PR, when an array is passed as body, the content-type is forced to `application/x-www-form-urlencoded`. This allows setting a content-type in the default options and have it overridden when passing an array as body. Spotted while reviewing #45791, where the proposed behavior would have allowed a cleaner patch. Commits ------- 91099a9 [HttpClient] Improve default content-type handling
|
Thank you @tomasz-kusy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.