Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TwigBridge] Fix the build #45905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Apr 1, 2022
Merged

[TwigBridge] Fix the build #45905

merged 0 commits into from
Apr 1, 2022

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Mar 31, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix part of CI
License MIT
Doc PR n/a
  • The changes in [TwigBridge] fix bootstrap_3_layout ChoiceType's expanded label_html #45897 missed the space between widget and label. Afaik, there is no other way to force the space than moving the if statement on the same line.
  • I've removed PHPunit bridge from require-dev in the subtree splits. The PHPunit bridge is installed by the monorepo during local testing. Depending on it in subpackage's composer.json can create conflicts between the version installed by the monorepo and the subtree split package (especially on deps=low builds). The build was broken due to mixing up 4.4.0 and 6.1-dev in deps=low.
  • Finally, Appveyor seems to need to run a second time on each version branch for 8016293 to work. Not sure why, but if it works it works 🏃

@carsonbot carsonbot added this to the 5.4 milestone Mar 31, 2022
@wouterj wouterj changed the title [TwigBridge] Fix whitespace control in boostrap 3 layout [TwigBridge] Fix the build Mar 31, 2022
@wouterj wouterj changed the title [TwigBridge] Fix the build [TwigBridge][DoctrineBridge] Fix the build Mar 31, 2022
@carsonbot carsonbot changed the title [TwigBridge][DoctrineBridge] Fix the build [TwigBridge] Fix the build Apr 1, 2022
@fabpot
Copy link
Member

fabpot commented Apr 1, 2022

Thank you @wouterj.

@fabpot fabpot merged commit 08966f7 into symfony:5.4 Apr 1, 2022
@wouterj wouterj deleted the fix-build-54 branch April 1, 2022 06:10
This was referenced Apr 2, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBridge
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterj @fabpot @carsonbot