[HttpClient] on redirections don't send content related request headers #45906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Apr 1, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #45709, #45735 |
| License | MIT |
| Doc PR |
8743696 to
7804522
Compare
7804522 to
d7c1361
Compare
|
Good catch, thanks @xabbuh. |
This was referenced Apr 2, 2022
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Apr 12, 2022
… body (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Fix sending content-length when streaming the body | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #45965 | License | MIT | Doc PR | - Follows #45906 and previous PRs on the topic. This PR partly reverts previous changes but keeps tests added to cover how we manage content-related headers when redirecting. Relying on curl doesn't work in all cases, so we need to manage them on our own. Commits ------- ee57696 [HttpClient] Fix sending content-length when streaming the body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.