[Messenger] reset connection on worker shutdown #45910
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -101,7 +101,7 @@ public function run(array $options = []): void | |||
| } | |||
| } | |||
|
|
|||
| $this->dispatchEvent(new WorkerStoppedEvent($this)); | |||
| $this->dispatchEvent(new WorkerStoppedEvent($this, $this->receivers)); | |||
There was a problem hiding this comment.
I'd prefer not adding a new class + argument
instead, we could add the reset loop after this call, isn't it?
There was a problem hiding this comment.
True, good idea 👍
998c0eb to
c486305
Compare
|
Thank you @SanderHagen. |
As seen in the issue. Amazon SQS transport uses a buffer. Messages can be lost when the buffer contains these messages and some container executing the process is shut down. The connection contains a reset method and implements the
ResetInterface. If this method were to be called on shutdown the messages will be marked as visible again.