Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Process] Fix Process::getEnv() when setEnv() hasn't been called before#45931

Merged
nicolas-grekas merged 1 commit intosymfony:4.4from
asika32764:patch-1
Apr 4, 2022
Merged

[Process] Fix Process::getEnv() when setEnv() hasn't been called before#45931
nicolas-grekas merged 1 commit intosymfony:4.4from
asika32764:patch-1

Conversation

@asika32764
Copy link
Copy Markdown
Contributor

@asika32764 asika32764 commented Apr 4, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT

AS getEnv() return type is array, if a Process object has no default env and is NULL value, calling getEnv() will get error.

$process = $someObject->createProcess(); // Get process from some object, but we don't know the environment

// We want to check the env
$env = $process->getEnv(); // Error: return type must be array, NULL given.

@carsonbot carsonbot added this to the 6.1 milestone Apr 4, 2022
@carsonbot
Copy link
Copy Markdown

carsonbot commented Apr 4, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@asika32764 asika32764 changed the base branch from 6.1 to 6.0 April 4, 2022 09:05
@asika32764 asika32764 changed the base branch from 6.0 to 6.1 April 4, 2022 09:05
@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 4.4 Apr 4, 2022
nicolas-grekas
nicolas-grekas reviewed Apr 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
I think it might be better to initialize the property to the empty array, then we wouldn't have to patch this method.
Also, since this is a bugfix, it should target 4.4, and should have a test case. Can you add one please? (I can handle the re-targeting while merging)

@asika32764
Copy link
Copy Markdown
Contributor Author

asika32764 commented Apr 4, 2022

Sorry I have heavy work on my job, so I'm afraid that I'm not available to do future works.

Just fix it thought your standard way, thanks.

@carsonbot carsonbot changed the title Make Process::getEnv() default return array if is NULL [Process] Make Process::getEnv() default return array if is NULL Apr 4, 2022
@nicolas-grekas nicolas-grekas changed the title [Process] Make Process::getEnv() default return array if is NULL [Process] Fix Process::getEnv() when setEnv() hasn't been called before Apr 4, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.1 to 4.4 April 4, 2022 10:15
@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Apr 4, 2022

Thanks @asika32764.

@nicolas-grekas nicolas-grekas merged commit 81c9e39 into symfony:4.4 Apr 4, 2022
This was referenced Apr 27, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh

@lyrixx lyrixx Awaiting requested review from lyrixx

@dunglas dunglas Awaiting requested review from dunglas

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

Assignees

No one assigned

Labels

Bug Process Status: Needs Review

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@asika32764 @carsonbot @nicolas-grekas