[Uid] Added toHexString method to AbstractUid class #45939
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR.
This relates to #42966. In order to completely implement the issue, we should also patch the uuid:inspect and uuid:inspect commands to display that number.
This is a new feature so it should target branch 6.1.
| /** | ||
| * Returns the identifier as a prefixed hexadecimal case insensitive string. | ||
| */ | ||
| public function toHexString(): string |
There was a problem hiding this comment.
toHex() to be enough and better to me
|
I had to open new PR because source branch has changed #45945 |
fabpot
added a commit
that referenced
this pull request
Jul 20, 2022
…urimasniekis) This PR was merged into the 6.2 branch. Discussion ---------- [Uid] Added toHexString method to AbstractUid class | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Fix | #42966 | License | MIT Added a small method to Uid component `AbstractUid` class called `toHex` which would output binary value of identifier as prefixed hex string for e.g. `0x0000000`. This is really useful when using with Doctrine for Id generation as the storage of Uid is a binary format in the database, and in most cases, it is usually used with hex format to query it. This PR is from #45939 as I needed to change the source branch to 6.1 Commits ------- dad28d6 Added toHexString method to AbstractUid class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small method to Uid component
AbstractUidclass calledtoHexStringwhich would output binary value of identifier as prefixed hex string for e.g.0x0000000. This is really useful when using with Doctrine for Id generation as the storage of Uid is a binary format in the database, and in most cases, it is usually used with hex format to query it.