Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TwigBridge] Make LintCommand::$namePatterns private #45941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

[TwigBridge] Make LintCommand::$namePatterns private #45941

merged 1 commit into from
Apr 4, 2022

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Apr 4, 2022 •
edited
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Dunno why this wasn't done in #45845. /cc @GromNaN any idea?

@carsonbot carsonbot added this to the 6.1 milestone Apr 4, 2022
@GromNaN
Copy link
Member

GromNaN commented Apr 4, 2022 •
edited
Loading

The attribute is used by child class Symfony\Bundle\TwigBundle\Command\LintCommand. Psalm found the issue.

Is there any alternative? Adding a protected getNamePattern? Auto-append the Finder instance returned by findFiles?

@nicolas-grekas nicolas-grekas requested a review from yceruto as a code owner April 4, 2022 18:24
@nicolas-grekas
Copy link
Member Author

Understood, thanks. Fixed.

GromNaN
GromNaN approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant.

GromNaN
GromNaN reviewed Apr 4, 2022
View reviewed changes
@GromNaN
Copy link
Member

GromNaN commented Apr 4, 2022

Good catch, thanks @nicolas-grekas.

@GromNaN GromNaN merged commit 9c37015 into symfony:6.1 Apr 4, 2022
@nicolas-grekas nicolas-grekas deleted the twig-priv branch April 11, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Reviewed TwigBridge
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @GromNaN @carsonbot