Leverage array_is_list(), get_debug_type(), is_countable(), is_iterable(), str_contains() and str_starts_with() #45978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le(), str_contains() and str_starts_with()
fancyweb
commented
Apr 8, 2022
| @@ -56,7 +56,7 @@ protected function matches($crawler): bool | |||
| $this->hasNode = true; | |||
| $this->nodeText = $crawler->text(null, true); | |||
|
|
|||
| return false !== mb_strpos($this->nodeText, $this->expectedText); | |||
| return str_contains($this->nodeText, $this->expectedText); | |||
There was a problem hiding this comment.
From the str_contains RFC:
In a recent discussion in the internals mailing list, we came to the conclusion, there is no need for a multibyte variant of this function (e.g. mb_str_contains). The reason behind this is: A multibyte variant of this function would behave no different than the non-multibyte function. Multibyte variants behave differently when the offset/position has relevance at which the string was found. As this is not the case for this function, there is no need for that.
And from what I understood, it's the same for str_starts_with() and str_ends_with().
yceruto
approved these changes
Apr 8, 2022
GromNaN
approved these changes
Apr 8, 2022
Tobion
approved these changes
Apr 9, 2022
fabpot
approved these changes
Apr 9, 2022
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2022
… code paths (nicolas-grekas) This PR was merged into the 6.1 branch. Discussion ---------- [Cache][String] Don't use is_iterable() in perf-critical code paths | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This is 5 times faster than calling `is_iterable()` Partially reverting #45978 /cc `@fancyweb` FYI. Commits ------- 33fa00c [Cache][String] Don't use is_iterable() in perf-critical code paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some things from the "past" again 😄