[Translation] Get domains from provider if them are not specified explicitly #45999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
247d038 to
abd0805
Compare
welcoMattic
reviewed
Apr 12, 2022
| @@ -133,7 +132,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $localTranslations = $this->readLocalTranslations($locales, $domains, $this->transPaths); | |||
|
|
|||
| if (!$domains) { | |||
| $domains = $this->getDomainsFromTranslatorBag($localTranslations); | |||
| $domains = $provider->getDomains(); | |||
There was a problem hiding this comment.
We need to check if $provider has getDomains method here, as it's done here https://github.com/symfony/symfony/pull/45171/files#diff-a00f86baf85c337ee61148e5fff8d189edf224ef40382518307359f579f40e6aR136
|
@ossinkine Thank you for the contribution. Can you add a test to cover this change please? |
|
Looks like it's already fixed in #45171, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
translation:pullgets domains from provider configuration if them are not specified in options buttranslation:pushgets domans from local catalog. I find that the same behavior is more predictable in this case.symfony/src/Symfony/Component/Translation/Command/TranslationPullCommand.php
Lines 154 to 156 in 1f514f9