Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] Fix Symfony not working on SMB share #46012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

[HttpKernel] Fix Symfony not working on SMB share #46012

merged 1 commit into from
Apr 12, 2022

Conversation

qinshuze
Copy link
Contributor

@qinshuze qinshuze commented Apr 12, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #45990
License MIT
Doc PR -

@carsonbot carsonbot added this to the 4.4 milestone Apr 12, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fix Symfony not working on SMB share #45990 [HttpKernel] Fix Symfony not working on SMB share #45990 Apr 12, 2022
@nicolas-grekas nicolas-grekas changed the title [HttpKernel] Fix Symfony not working on SMB share #45990 [HttpKernel] Fix Symfony not working on SMB share Apr 12, 2022
nicolas-grekas
nicolas-grekas approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please just confirm that this fixes the issue for you)

@nicolas-grekas
Copy link
Member

Thank you @qinshuze.

@nicolas-grekas nicolas-grekas merged commit 76f6d74 into symfony:4.4 Apr 12, 2022
@qinshuze qinshuze deleted the 4.4 branch April 12, 2022 14:27
@qinshuze
Copy link
Contributor Author

(please just confirm that this fixes the issue for you)
yes this solved my issue

@qinshuze qinshuze restored the 4.4 branch April 12, 2022 14:35
This was referenced Apr 27, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@qinshuze @carsonbot @nicolas-grekas