Minor cleanup #46043
Merged
Minor cleanup #46043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Apr 14, 2022
| @@ -71,11 +71,11 @@ class UnusedTagsPass implements CompilerPassInterface | |||
| 'property_info.list_extractor', | |||
| 'property_info.type_extractor', | |||
| 'proxy', | |||
| 'routing.condition_service', | |||
There was a problem hiding this comment.
The tags are sorted alphabetically.
fancyweb
commented
Apr 14, 2022
| @@ -37,10 +37,10 @@ public function __construct(string $enum, \BackedEnum ...$cases) | |||
| } | |||
| } | |||
|
|
|||
| $this->values = array_unique(array_map( | |||
| $this->values = array_map( | |||
There was a problem hiding this comment.
array_unique is useless now that all cases comes from the same enum
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing #44405 when it was merged. I had some minor fixes to do so I added them to this PR.