[Security] Add a ChainUserChecker to allow calling multiple user checkers for a firewall#46064
Merged
Merged
Conversation
b79f4f8 to
fdf2d0f
Compare
stof
reviewed
Apr 15, 2022
fdf2d0f to
4661374
Compare
ChainUserChecker to allow calling multiple user checkers for a firewall
4661374 to
e111ec8
Compare
e111ec8 to
d5aef06
Compare
d5aef06 to
23fbfe1
Compare
1b73f8f to
711b918
Compare
maxhelias
approved these changes
Sep 12, 2022
derrabus
approved these changes
Sep 12, 2022
711b918 to
0a1ad4b
Compare
fabpot
approved these changes
Sep 13, 2022
Member
|
Thank you @mbabker. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a case in one of my apps where I have some shared logic for user checkers across multiple firewalls (API and traditional web login) while also needing extra logic for the API. Instead of duplicating the checker for each firewall or using a decorator, I thought a chained user checker would be nice to have and that it might be useful to users of the framework.
This will add a
ChainUserCheckerclass to thesecurity-corecomponent, and the SecurityBundle will create asecurity.user_checker.chain.<firewall>service for each firewall. User checkers can then be tagged with asecurity.user_checker.<firewall>tag for each firewall the checker applies to, and users would set this chain service as the user checker for their firewall.