[Routing] fix router base url when default uri has trailing slash #46097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Apr 18, 2022
| $this->assertSame('test.com', $requestContext->getHost()); | ||
| $this->assertSame(8080, $requestContext->getHttpPort()); | ||
| $this->assertSame(443, $requestContext->getHttpsPort()); | ||
| $this->assertSame('', $requestContext->getBaseUrl()); |
There was a problem hiding this comment.
this is the main fix. all others are just adding missing test cases.
5b9b708 to
d60a6b8
Compare
d60a6b8 to
07136a9
Compare
|
Shouldn't this target 4.4? |
|
Well in Symfony the problem is only exposed since the default_uri config which was introduced in 5.x |
nicolas-grekas
approved these changes
Apr 19, 2022
|
Thank you @Tobion. |
This was referenced Apr 27, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the router default uri (feature #36651) has a trailing slash, the generated URLs are wrong. E.g.
Generating any absolute URL given this base path currently resulted in double slashes, e.g.
https://example.org//mypagebecause the base url is set to
/and the path info defaults to/as well. This is not correct and will result in a 404.The most consistent fix with the rest of symfony is to always rtrim the trailing slashes from the base url.
This is already done in the HttpFoundation Request class see
symfony/src/Symfony/Component/HttpFoundation/Request.php
Line 849 in 674ad07
So I think it makes sense to enforce this also on the requestcontext so it is also the case when it does not go through the fromRequest but via fromUri in the CLI.