-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security] Don't allow empty username or empty password #46118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a BC break, which Symfony doesn't allow in minor versions. We need to deprecate passing empty strings at first, then convert the deprecation to an error in the next major version. |
1a80ed6
to
97c716e
Compare
@chalasr Do I need to create a new |
We'll create the 6.2 after the stabilization period, you can then rebase this PR on the new 6.1 branch. I guess you can create a new |
src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php
Outdated
Show resolved
Hide resolved
71e61b2
to
db5afbd
Compare
Thank you @bikalbasnet. |
Just came across this in some application tests. Right now I get the 401 HTTP status code and the user deprecation. What is the upcoming target? From the other closed commits I assume 400 HTTP status code instead? The naming |
@adrianrudnik I'm not sure to truly understand what is the question here. |
Reopened from #46109 into
6.1
branch as this is not a bug rather a security feature