[DomCrawler] Failing test for Crawler emojis handling regression #46212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since 4.4.39, 5.4.6 and 6.0.6
|
The default charset in the HTML spec is not UTF-8 but ISO-8859-1. So you indeed need to specify the charset as UTF-8 if you use UTF-8 content (and you cannot use emojis in ISO-8859-1). It was not a misuse of the Crawler. It was a misuse of HTML. |
|
Still, I'm double-asking considering: symfony/src/Symfony/Component/DomCrawler/Crawler.php Lines 127 to 134 in fe63f83 Note: $crawler = new Crawler();
$crawler->addHtmlContent('<body><p>Hey 👋</p></body>', 'UTF-8');would not work either. |
|
Good catch thanks! |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 30, 2022
…grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DomCrawler][VarDumper] Fix html-encoding emojis | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46212 | License | MIT | Doc PR | - Commits ------- 26fbc96 [DomCrawler][VarDumper] Fix html-encoding emojis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since 4.4.39, 5.4.6 and 6.0.6.
This is the minimal reproducer for an issue we encountered on our blog while upgrading to 5.4.6 (this probably goes beyond emojis issues).
Our contents are parsed from markdown files, converted to HTML, then read using the Crawler to performs some checks and modifications. But since the upgrades, emojis included in the original content were wrongly encoded:
These changes are the culprit: https://github.com/symfony/symfony/pull/45532/files#diff-940b51ffa31dedac17aa49cd8e04e44aa8b3747782c7f9f27457b0510587c05d
However, I'm unsure this is an actual regression, or somehow a misuse of the Crawler, since adding:
in the test case would fix it?