[Console] Fix fish completion script #46220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Apr 30, 2022
fabpot
approved these changes
Apr 30, 2022
1919457 to
0d1b980
Compare
|
Thank you @wouterj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out the fish completion support, I discovered a syntax error in the fish script. After fixing it, I realized the cursor calculation was wrong in the fish script. I've tested these changes using Fish 3.4.1 and the Symfony demo app.
Meanwhile, I improved the help of the
completioncommand to account for the fish shell support. I had to find the PR that introduced this feature in order to get installation instructions (these are now part of the help - just like with bash).