Bootstrap 4 fieldset for row errors #46414
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Thank you @konradkozaczenko. |
| @@ -49,6 +49,7 @@ col-sm-2 | |||
| <div class="{{ block('form_group_class') }}"> | |||
| {{- form_widget(form, widget_attr) -}} | |||
| {{- form_help(form) -}} | |||
| {{- form_errors(form) -}} | |||
There was a problem hiding this comment.
Is this really necessary as the errors should be rendered when the label is rendered?
When using bootstrap_4_horizontal_layout.html and ChoiceType on a form with expanded and multiple options, the checkbox list is rendered, but no errors are displayed. My changes only affect bootstrap version 4. Bootstrap 5 already has these changes.