[FrameworkBundle] update docblock to not expose the internal class #46496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this resolves issue #46483. |
stof
approved these changes
May 30, 2022
|
Thank you @xabbuh. |
|
The overall issue seems to be still present. Due to the changes on the return types, That's my snippet from my test case use Prophecy\PhpUnit\ProphecyTrait;
use Company\Api\Command\Command;
use Company\Api\Entity\Entity;
use Company\Api\Repository\EntityRepository;
use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Component\Console\Tester\CommandTester;
class CommandTest extends KernelTestCase
{
use ProphecyTrait;
public function testExecute(): void
{
$container = self::getContainer();
$entityRepository = $container->get(EntityRepository::class);
$entity = $entityRepository->find('_entity_id_');
// ...
}
}Removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was introduced in #44695 motivated by the idea to be able to use the
getServiceIds()andgetRemovedIds()methods which are Symfony-specific methods. Exposing theTestContainerhas the drawback of static analysis tools complaining about making use of internal classes. Since the interesting methods are part of the baseContainerclass which is not internal I propose to change the docblock to return an instance of this class instead.