Added missing "__call" to TraceableNormalizer #46509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 6.1: do not accept array input when a form is not multiple Update PR template [FrameworkBundle] fix tests Fix merge [Mime] Throw exception when body in Email attach method is not ok [VarDumper][VarExporter] Deal with DatePeriod->include_end_date on PHP 8.2 [Cache] Throw when "redis_sentinel" is used with a non-Predis "class" option New bundle path convention when AbstractBundle is used fix merge Bootstrap 4 fieldset for row errors [Form] Fix same choice loader with different choice values [Filesystem] Safeguard (sym)link calls Fix dumping extension config without bundle [HttpClient] Honor "max_duration" when replacing requests with async decorators [FrameworkBundle] Simplify registration of #[AsRoutingConditionService] [HttpClient] Add missing HttpOptions::setMaxDuration() [HttpKernel] Fix missing null type in `ErrorListener::__construct()` [HttpFoundation] [Session] Overwrite invalid session id
* 6.1: Fix merge Fix merge [FrameworkBundle] fix tests [FrameworkBundle] fix wiring of annotations.cached_reader [SecurityBundle] Remove dead `class_exists` checks Fix BC break [DependencyInjection] Ignore unused bindings defined by attribute [ErrorHandler] update tentative types
* 6.1: [DoctrineBridge] Don't reinit managers when they are proxied as ghost objects Revert "bug #46125 [FrameworkBundle] Always add CacheCollectorPass (fancyweb)"
* 6.1: [ExpressionLanguage] Fix null-safe chaining [Console] Complete negatable options (Fish) [PropertyInfo] Fix resolution of partially docblock covered constructors [DependencyInjection] Fix "proxy" tag: resolve its parameters and pass it to child definitions Complete negatable options
…erve PHP references when using it (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [DependencyInjection] Add Hydrator::hydrate() and preserve PHP references when using it | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - To make it easy to hydrate already created objects (usually created without calling the constructor.) * Add `Hydrator::hydrate()` * Preserve PHP references also when using `Hydrator::hydrate()` or `Instantiator::instantiate()` * Add support for hydrating from native (array) casts Commits ------- e1a8502 [VarExporter] Add `Hydrator::hydrate()` and preserve PHP references when using it
* 6.1: [MonologBridge] Add Test for FirePHPHandler Fix typo ensure that the $response property is initialized before being read CS fix Bump Symfony version to 6.1.1 Update VERSION for 6.1.0 Update CHANGELOG for 6.1.0 Bump Symfony version to 6.0.10 Update VERSION for 6.0.9 Update CHANGELOG for 6.0.9 Bump Symfony version to 5.4.10 Update VERSION for 5.4.9 Update CHANGELOG for 5.4.9 Bump Symfony version to 4.4.43 Update VERSION for 4.4.42 Update CONTRIBUTORS for 4.4.42 Update CHANGELOG for 4.4.42
…-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [DependencyInjection] Optimize dumped container | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 9e32833 [DependencyInjection] Optimize dumped container
…ror pages (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [ErrorHandler][HttpKernel] Add favicon to welcome and error pages | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Similar to symfony/recipes#1023, saves some spammy http requests when displaying those pages. Commits ------- af57714 [HttpKernel][ErrorHandler] Add favicon to welcome and error pages
…op and Sulu! (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- Update backers of Symfony 6.2: thank you Les-Tilleuls.coop and Sulu! | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Thank you Les-Tilleuls.coop and Sulu! /cc `@dunglas` `@chalasr` `@GregoireHebert` /cc `@chirimoya` `@alexander`-schranz Note that there is a 3rd sponsor slot remaining for 6.2, and we're now looking for sponsors for 6.3. Feel free to [reach me](https://symfony.com/support) to know more :) Commits ------- b229826 Update backers of Symfony 6.2: thank you Les-Tilleuls.coop and Sulu!
…ling it about excluded symbols (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [DependencyInjection] Optimize autowiring logic by telling it about excluded symbols | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replaces #46275 While inspecting the dumped container of the demo app, I noticed that it contains so-called "errored" services. They come e.g from entities that are used as type-hints on controllers. To compute those services, the autowiring logic currently loads all services looking for possible type-compatible candidates. But here, we should know that those won't be found: they're excluded from being loaded. Instead of completely ignoring excluded classes, this PR still registers them, but as abstract and with a special `container.excluded` tag. This allows the rest of the compilation logic to skip+remove them, while allowing `AutowiringPass` to compute a better error message and way faster. Here is the relevant part of a https://blackfire.io comparison:  Commits ------- 739789f [DependencyInjection] Optimize autowiring logic by telling it about excluded symbols
…ds and pagination (HeahDude) This PR was merged into the 6.2 branch. Discussion ---------- [Routing] Add `Requirement::POSITIVE_INT` for common ids and pagination | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #45528 | License | MIT | Doc PR | ~ I targeted 6.1 because it's not yet released, should I rebase onto 6.2? ping `@fancyweb` :) Commits ------- bea54e6 [Routing] Add `Requirement::POSITIVE_INT` for common ids and pagination
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Thanks for the PR. Please rebase against 6.1 (https://symfony.com/doc/current/contributing/code/pull_requests.html#rebase-your-pull-request) |
|
Can you please do the same on https://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/Serializer/Debug/TraceableSerializer.php? |
Working on it |
|
Not gonna lie, I don't know how to fix this. I get tons of merge conflicts. I submitted a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing
__callmethod to the new TraceableNormalizer.This method was forgotten and breaks custom normalizers that have public methods outside of the NormalizerInterface.
This approach is already being used for TreaceableAuthenticator, TraceableEventDispatcher, LoggingTranslator etc...