[Validator] deprecate the loose e-mail validation mode #46518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 31, 2022
| Q | A |
|---|---|
| Branch? | 6.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Tickets | Fix #41855 |
| License | MIT |
| Doc PR |
stof
reviewed
May 31, 2022
src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
Outdated
Show resolved
Hide resolved
stof
approved these changes
May 31, 2022
nicolas-grekas
approved these changes
Jun 1, 2022
fabpot
approved these changes
Jun 2, 2022
|
Thank you @xabbuh. |
Merged
ghost
reviewed
Nov 21, 2022
| @@ -68,6 +71,10 @@ public function __construct( | |||
| $this->mode = $mode ?? $this->mode; | |||
| $this->normalizer = $normalizer ?? $this->normalizer; | |||
|
|
|||
| if (self::VALIDATION_MODE_LOOSE === $this->mode) { | |||
| trigger_deprecation('symfony/validator', '6.2', 'The "%s" mode is deprecated. The default mode will be changed to "%s" in 7.0.', self::VALIDATION_MODE_LOOSE, self::VALIDATION_MODE_HTML5); | |||
There was a problem hiding this comment.
Will the default be changed or will the validation mode be removed?
| @@ -27,6 +27,9 @@ class Email extends Constraint | |||
| { | |||
| public const VALIDATION_MODE_HTML5 = 'html5'; | |||
| public const VALIDATION_MODE_STRICT = 'strict'; | |||
| /** | |||
| * @deprecated since Symfony 6.2 | |||
There was a problem hiding this comment.
@deprecated since Symfony 6.2, use VALIDATION_MODE_HTML5 instead?
|
@johanadivare sorry for the late feedback, please see #49420 |
fabpot
added a commit
that referenced
this pull request
Feb 20, 2023
This PR was merged into the 6.2 branch. Discussion ---------- improve deprecation message | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #46518 (comment) and #46518 (comment) | License | MIT | Doc PR | Commits ------- 54a1d1b improve deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.