[WebProfilerBundle] Fix dark theme selected line highlight color & reuse css vars #46565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jun 3, 2022
fabpot
approved these changes
Jun 3, 2022
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jun 5, 2022
…source code (ogizanagi) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Serializer][WebProfilerBundle] Collect & show caller source code | Q | A | ------------- | --- | Branch? | 6.2 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | N/A | License | MIT | Doc PR | N/A As for the Messenger and Validator panels, knowing from which code was called the Serializer's methods and jumping to it in one click is useful to get a better understanding of each collected rows and their context.    --- the second commit relates to #46565 Commits ------- 0a20712 Fix dark theme highlight color & reuse css vars 83412d2 [Serializer][WebProfilerBundle] Collect & show caller source code
Merged
This was referenced Jun 26, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the profiler with a dark theme,
the Messenger panel was missing using the dedicated vars and was still using a light bg:
and the selected lines on file excerpts (for any panel) are not contrasted enough:
I suggest using a more contrasted highlight color for selected lines: