[HttpClient] Fix json encode flags usage in copy-as-curl generation #46670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
json_encode($json, \JSON_PRETTY_PRINT)
call to generate the cURL version of a HTTP Request in HttpClientDataCollector didn't use theself::jsonEncode
method available.The main issue with that is the usage of
\JSON_PRETTY_PRINT
, which is overwrites all other flags inself::jsonEncode
method, especially\JSON_PRESERVE_ZERO_FRACTION
.So I have added a test for it:
After the changes, this test pass ✅
I've added test for all other flags, to be sure that they are used. It could lead to less readable JSON (with hex values) displayed in Profiler, but it's more accurate to debug.
EDIT: removing
\JSON_PRETTY_PRINT
solve the problem too, and we don't need to pretty-print the JSON in curl command, it allows to run the exact same request.