Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] Respect $save option in all adapters #46699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2022
Merged

[Cache] Respect $save option in all adapters #46699

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e8de1e
[Cache] Respect $save option in ArrayAdapter
jrjohnson Jun 17, 2022
b14aa77
[Cache] Respect $save option in ChainAdapter
nicolas-grekas Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Cache] Respect $save option in ChainAdapter
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Jun 19, 2022
commit b14aa77e4debf903507899bb85ec6015a7382cad
11 changes: 10 additions & 1 deletion src/Symfony/Component/Cache/Adapter/ChainAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,17 @@ static function ($sourceItem, $item, $sourceMetadata = null) use ($defaultLifeti
*/
public function get(string $key, callable $callback, float $beta = null, array &$metadata = null)
{
$doSave = true;
$callback = static function (CacheItem $item, bool &$save) use ($callback, &$doSave) {
$value = $callback($item, $save);
$doSave = $save;

return $value;
};

$lastItem = null;
$i = 0;
$wrap = function (CacheItem $item = null) use ($key, $callback, $beta, &$wrap, &$i, &$lastItem, &$metadata) {
$wrap = function (CacheItem $item = null, bool &$save = true) use ($key, $callback, $beta, &$wrap, &$i, &$doSave, &$lastItem, &$metadata) {
$adapter = $this->adapters[$i];
if (isset($this->adapters[++$i])) {
$callback = $wrap;
Expand All @@ -107,6 +115,7 @@ public function get(string $key, callable $callback, float $beta = null, array &
if (null !== $item) {
($this->syncItem)($lastItem = $lastItem ?? $item, $item, $metadata);
}
$save = $doSave;

return $value;
};
Expand Down