[Mailer] Deprecate OhMySmtp Transport, Create MailPace transport #46714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
reviewed
Jun 20, 2022
src/Symfony/Component/Mailer/Bridge/OhMySmtp/Transport/OhMySmtpApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/OhMySmtp/Transport/OhMySmtpSmtpTransport.php
Outdated
Show resolved
Hide resolved
stof
requested changes
Jun 20, 2022
src/Symfony/Component/Mailer/Bridge/MailPace/Transport/MailPaceApiTransport.php
Outdated
Show resolved
Hide resolved
|
All comments were taken into account. PS: What is the process for this? Should I resolve the comments when I push the changes or should the original author of the comment review the touched code once again and resolve it himself? Thanks! |
|
@Holicz you can resolve comment (if needed, we can unresolve it) |
fabpot
approved these changes
Jun 25, 2022
|
Thank you @Holicz. |
fabpot
added a commit
that referenced
this pull request
Jun 25, 2022
… transport (Holicz) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [Mailer] Deprecate OhMySmtp Transport, Create MailPace transport | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Tickets | Fix #46340 | License | MIT | Doc PR | symfony/symfony-docs#16896 OhMySMTP duplicate was created and renamed to MailPace. OhMySMTP was deprecated. Commits ------- dd2d6ed [Mailer] Deprecate OhMySmtp Transport, Create MailPace transport
|
@Holicz Can you submit a PR on symfony/recipes and one for the docs? |
|
Sure, Docs: symfony/symfony-docs#16896 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OhMySMTP duplicate was created and renamed to MailPace. OhMySMTP was deprecated.