Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Add SMSFactor bridge #46724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2022
Merged

[Notifier] Add SMSFactor bridge #46724

merged 1 commit into from
Jun 25, 2022

Conversation

Gwemox
Copy link
Contributor

@Gwemox Gwemox commented Jun 20, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#16901
Recipe PR symfony/recipes#1102

Provides SMSFactor integration for Symfony Notifier.

@Gwemox Gwemox requested a review from OskarStark as a code owner June 20, 2022 15:29
@carsonbot carsonbot added this to the 6.2 milestone Jun 20, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Gwemox Gwemox force-pushed the notifier_sms_factor branch 4 times, most recently from 6a1a9aa to a8e1667 Compare June 20, 2022 16:08
OskarStark
OskarStark reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new bridge 😃

src/Symfony/Component/Notifier/Bridge/SmsFactor/composer.json
"require": {
"php": ">=8.1",
"symfony/http-client": "^5.4|^6.0",
"symfony/notifier": "^5.4|^6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does not work with notifier 5.4, must be 6.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test this?

@Gwemox Gwemox mentioned this pull request Jun 20, 2022
Merged
@Gwemox Gwemox force-pushed the notifier_sms_factor branch from a8e1667 to f9286ff Compare June 21, 2022 07:10
@Gwemox Gwemox force-pushed the notifier_sms_factor branch from f9286ff to 5204f0f Compare June 24, 2022 08:21
@Gwemox Gwemox requested a review from OskarStark June 24, 2022 08:26
@Gwemox Gwemox requested a review from fabpot June 24, 2022 08:26
@fabpot
Copy link
Member

fabpot commented Jun 25, 2022

Thank you @Gwemox.

@fabpot fabpot merged commit 8974959 into symfony:6.2 Jun 25, 2022
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jul 4, 2022
@javiereguiluz
minor #16901 [Notifier] [SMSFactor] add docs (Gwemox)
9eda4b9 
This PR was merged into the 6.2 branch.

Discussion
----------

[Notifier] [SMSFactor] add docs

Add SMSFactor docs symfony/symfony#46724

Commits
-------

80a0506 [Notifier] [SMSFactor] add docs
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Gwemox @carsonbot @fabpot @OskarStark