fix query explanation table width restrictions #46750
Conversation
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @Amunak has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
| max-width: 888px; | ||
| } | ||
| .width-full .sql-explain { | ||
| max-width: min-content; |
There was a problem hiding this comment.
Here we could even use max-width: unset to not restrict the max width, what do you think?
There was a problem hiding this comment.
Thank you Javier for taking the time to review my pull request. I'm OK with the suggested change.
Let me know if I should make that change. Not sure about the workflow here since it's my first PR.
There was a problem hiding this comment.
Maybe max-width: fit-content? Unset would make simple explain windows too wide on big screens.
as opposed to
But it's your call. We could go either way.
There was a problem hiding this comment.
Sorry I didn't reply earlier. Don't worry about this. Now that this is merged, people can test it for real and if there's any issue we'll get reports. So, everything is fine. Thanks!
|
Thank you @zolikonta. |
|
Great. Thank you guys! |
… with Postgresql (stof) This PR was merged into the 6.2 branch. Discussion ---------- [WebProfilerBundle] Fix the rendering of query explanation with Postgresql | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | n/a Postgresql (and some other platforms) provide a textual query explanation rather than a tabular one. The previous styles were working only for a tabular display. For text allowing to break words, `min-content` is the width of a single letter. With the old code (introduced in #46750), a query explanation looks like that when using Postgresql (well, with a lot more lines that what is included in the screenshot):  After the change, it looks like that (including only the first few lines), which is a lot easier to read:  Commits ------- f238349 Fix the rendering of query explanation with Postgresql
max width for query explanation table was too wide for Normal page width
max width for query explanation table was too narrow for Full-page