[Yaml] Add support for !php/enum *->value syntax
#46771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jun 24, 2022
b7fed5d to
a0f08e4
Compare
|
@stof PR updated, thanks for the review |
a0f08e4 to
f71e4ab
Compare
ogizanagi
approved these changes
Jun 24, 2022
fabpot
approved these changes
Jun 25, 2022
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows one to use the following Yaml together with enums:
The first line gets the
SomeEnum::Barinstance. It's the same as writing!php/const SomeEnum::Barbut with an additional check that this is really an enum.The second line is the one that is really needed as it allows referencing the value backed by an enum, which is something that is not possible currently.