Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Make AbstractController::render() able to deal with forms and deprecate renderForm() #46854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2022
Merged

[FrameworkBundle] Make AbstractController::render() able to deal with forms and deprecate renderForm() #46854

merged 1 commit into from
Jul 6, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? yes
Tickets -
License MIT
Doc PR -

No need for AbstractController::renderForm() when AbstractController::render() can do it!

@carsonbot carsonbot added this to the 6.2 milestone Jul 5, 2022
@HeahDude
Copy link
Contributor

HeahDude commented Jul 5, 2022

With this change the API becomes implicit and too magical, 👎 from me.

@fabpot
Copy link
Member

fabpot commented Jul 5, 2022

I suggested this change and I think it makes a lot of sense. The current method looks weird to me as it does not render a form ; it’s very confusing.

@HeahDude
Copy link
Contributor

HeahDude commented Jul 5, 2022

I see the point, maybe better phpdoc blocks would help describing what these methods do?

HeahDude
HeahDude reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with Nicolas, I admit I was already -1 on the previous implementation, so it might be better this way indeed.

chalasr
chalasr requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPGRADE note missing :)

@nicolas-grekas
Copy link
Member Author

UPGRADEd

@nicolas-grekas nicolas-grekas merged commit 7edbdf8 into symfony:6.2 Jul 6, 2022
@nicolas-grekas nicolas-grekas deleted the fwb-render-form branch July 6, 2022 12:28
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 6, 2022
Closed
@HeahDude HeahDude mentioned this pull request Jul 7, 2022
Closed
HeahDude added a commit to HeahDude/symfony that referenced this pull request Sep 16, 2022
@HeahDude
[FrameworkBundle] Add BC layer and FromView handling after symfony#46854
129ff27
HeahDude added a commit to HeahDude/symfony that referenced this pull request Sep 16, 2022
@HeahDude
[FrameworkBundle] Add BC layer and FromView handling after symfony#46854
5371f91
@HeahDude HeahDude mentioned this pull request Sep 16, 2022
Closed
HeahDude added a commit to HeahDude/symfony that referenced this pull request Sep 17, 2022
@HeahDude
[FrameworkBundle] Add BC layer and FormView handling after symfony#46854
45ca5ed
HeahDude added a commit to HeahDude/symfony that referenced this pull request Sep 18, 2022
@HeahDude
[FrameworkBundle] Add BC layer and FormView handling after symfony#46854
7a491db
HeahDude added a commit to HeahDude/symfony that referenced this pull request Sep 18, 2022
@HeahDude
[FrameworkBundle] Add BC layer and FormView handling after symfony#46854
867ae2f
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
@jdreesen jdreesen mentioned this pull request Nov 1, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

@chalasr chalasr chalasr requested changes

@dunglas dunglas dunglas approved these changes

@kbond kbond kbond approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Deprecation Feature FrameworkBundle Status: Needs Work
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
8 participants
@nicolas-grekas @HeahDude @fabpot @dunglas @kbond @lyrixx @chalasr @carsonbot